Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+proj=orthowith+alpha(Local Orthographic, like EPSG:10622) doesn't round-trip far from the centre. With the EPSG:10622 parameters, 60°W 30°S comes back as 58.82°W 31.02°S, ~160 km away on the hidden side of the globe. The oblique ellipsoidal inverse removes alpha and k, then seeds its Newton iteration withortho_s_inverse, which removes them a second time. Near the centre Newton still finds the right point, but far from it the iteration can land on the wrong one or not converge. This has been there since alpha and k were added in 9.5.0.This PR moves the spherical inverse math into a helper that takes the corrected coordinates, used by both
ortho_s_inverseand the initial guess. The spherical inverse itself is unchanged.