fix: stop logging plaintext new password in admin password reset - #918
Open
SeanDuggan wants to merge 1 commit into
Open
SeanDuggan wants to merge 1 commit into
SeanDuggan wants to merge 1 commit into
Conversation
log.debug(newPass = + newPassword) wrote the new plaintext password to the debug log whenever an admin reset a users password. Redact it, matching the existing pattern used for passwords elsewhere in the admin servlets (log the fact it was retrieved, not the value). Fixes OWASP#571
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #571