Repository navigation
fix(bindings): UIScene lifecycle for RN example apps on iOS 26+ - #517
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts UIScene lifecycle (required on iOS 26+) for all four React Native example apps:
examples/demo-appexamples/react-native-appexamples/nostr-exampleexamples/mesh-wikiWhat changed
SceneDelegate;AppDelegateconfigures the factory and scene.AppDelegate.windowis set forRCTDeviceInfoand related RN APIs.examples/shared/ios/ReactNativeSceneLaunchOptions.swiftmergesapplication(_:didFinishLaunchingWithOptions:)with sceneconnectionOptions(URL, notification, user activity) beforestartReactNative.main.jsbundlewhen present (demo README documents rebuild-after-JS for device Debug).IPHONEOS_DEPLOYMENT_TARGET15.1 in each example Podfilepost_install; sharedexamples/shared/ios/pod_fmt_consteval_patch.rbfor fmt / Xcode 26+ build failures.nkfin example Gemfiles where needed for Ruby 3.4+pod install.DevelopmentTeam.xcconfig.example(not wired into the Xcode target; signing still via Signing & Capabilities or your own xcconfig wiring).Verification
Manual iOS ↔ Android BLE smoke test on Offline Demo (iPhone 12, iOS 27.0.1): onboarding, People discovery, Chats messaging.
Test plan
xcodebuildsucceedspod install+ iOS build for react-native-app, nostr-example, mesh-wiki on Xcode 26+