Repository navigation
Restore the map pipeline so the mapserver can start - #10
Merged
Merged
Conversation
start.py and listMaps.py import mapmaker.maps, but that package was never committed, and terracotta was missing from requirements.txt, so the published image could not start. Restore the package from map-maker (1c17a2b) and use its current conventions: RGB is split into one COG per channel, and tile URLs carry explicit ranges. Also: - Allow the Ollebo dashboards in Terracotta's tile CORS; the default is localhost only. - Pin numpy/rasterio/terracotta and drop the unused ninja2 and geotiff. - Run secure_filename on the /mapmaker name. - Add a .dockerignore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AwkBcZCmo27zHnnRnAcKiy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
maincan't start.code/mapmaker/mapswas never committed andterracottaisn't in the requirements, so the app fails at startup. CI stays green because it only checks that the image builds.What changed
code/mapmaker/mapsfrommap-maker(1c17a2b):cog.py,detect.py,variants.py,terracotta_client.pyand the colour ramps. The default catalog path is now/data/db/terracotta.sqlite.makingGeotiff.pyto the restored module'sspec.build(...)signature, and made tile URLs followmap-maker's conventions.requirements.txt: added and pinnedterracotta==0.10.1,rasterio==1.4.3andnumpy<2, and removed the unusedninja2andgeotiff.localhostpages by default. The newterracotta.allowedOriginschart value defaults todash.ollebo.comanddash.northamlin.com, anddocker-compose.yamlsets the same origins./mapmakernow runs thenamefield throughsecure_filename..dockerignoreso test imagery and local data stay out of the image.Testing
Tested with
ollebo/mapserver:ef4b91a(built by hand and pushed to Docker Hub), installed with this chart on v2cluster and reached through a port-forward:rgbandgrayscalevariants in about 20 seconds200 image/pngAccess-Control-Allow-Originis sent forhttps://dash.ollebo.comand not for other originsdash.ollebo.com: not verified. The browser used for testing couldn't reach the port-forward, so its tile requests never got to the server.Before merging
mainmakes CI push to GHCR. GHCR refused an anonymous pull of the chart's default image, so customer installs may fail until that package's visibility is checked.Known gaps, not fixed here
OLLEBO_KEY, and dw's mapserverurlis hardcoded./mappage has no map viewer, despite what the README says.restrictedwarnings at install.🤖 Generated with Claude Code
https://claude.ai/code/session_01AwkBcZCmo27zHnnRnAcKiy