Repository navigation
security: mkdtempSync for mirror scratch + Dockerfile npm ci (v5.1.3) - #60
Merged
Merged
Conversation
…(v5.1.3) - Resolve the remaining js/insecure-temporary-file alert: mirrorJson() creates an exclusively-owned temp dir via fs.mkdtempSync() and writes inside it (a random filename alone did not satisfy CWE-377 because a test caller passes os.tmpdir()). Drop the now-unused crypto import. - Dockerfile: npm ci (lockfile integrity-hashed) instead of npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the last open
js/insecure-temporary-fileCodeQL alert and one supply-chain nit.js/insecure-temporary-file—mirrorJson()now creates an exclusively-owned scratch directory withfs.mkdtempSync()and writes inside it. A random filename alone didn't satisfy CWE-377 because a test caller passesos.tmpdir()into the function. Removed the now-unusedcryptoimport.npm ci(lockfile integrity-hashed install) instead ofnpm install.QA: 113 tests pass · lint clean · headers pass.
🤖 Addressed by Claude Code