Repository navigation
Give every admin page consistent padding and contain page crashes - #97
Merged
Merged
Conversation
Admin pages rendered straight into the shell's scroll area with no padding, so every page title, description and card sat flush against the sidebar, directly under the top bar, and ran to the right edge of the window. Only the "Coming soon" placeholder used PageContainer, which centered it in a 1280px box, so those pages were aligned differently from the rest. - AppShell wraps every page in <main className="shell-content"> with 24px/32px padding, full width and left-aligned. The existing 560px rule still drops it to 16px on phones. - PageContainer no longer adds its own padding or centering, so nothing is padded twice and the placeholders line up with every other page. - New PageErrorBoundary, keyed by the active page: a render error now shows an error with Retry inside the page instead of blanking the whole console (sidebar and top bar included) until a reload. - Hide the disabled "Search (coming soon)" box below 1700px, where it squeezed the breadcrumb to "Administrat... > Us...". Checked every sidebar page against a local admin build at 1600px and 1280px: titles now sit 32px from the sidebar and 24px below the top bar, and no page overflows horizontally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014t7uDmnjGZAyMrCYpN2RZy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Admin pages rendered straight into the shell with no padding:
PageContainer, which centered it in a 1280px box, so those pages were aligned differently from everything else.What
AppShell: wraps every page in<main className="shell-content">with 24px/32px padding, full width and left-aligned. The existing 560px rule still drops the padding to 16px on phones.PageContainer: no longer adds padding or centering, so nothing is padded twice and the placeholders line up with every other page.PageErrorBoundary(new, keyed by the active page): a render error now shows an in-page error with a Retry button, and the sidebar and top bar keep working.Checks
tsc -b,build:adminandbuild:controlare clean.🤖 Generated with Claude Code
https://claude.ai/code/session_014t7uDmnjGZAyMrCYpN2RZy
Generated by Claude Code