Repository navigation
feat: accept workspace.launch as an alternative to platform.manage_infra - #9
Merged
Merged
Conversation
Launching/stopping/creating a personal IDE workspace is a self-service action, not platform-infrastructure administration -- but every mutating route here required platform.manage_infra, an admin-only permission with no self-service equivalent. workspace.launch (omnibioai-auth's permission registry, grantable to a regular role like scientist) now satisfies the same gate; platform.manage_infra keeps working unchanged for admin accounts. requireIdentity accepts either a single permission name (every pre-existing call site) or an array where holding any one is sufficient. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launching/stopping/creating a personal IDE workspace is a self-service action, not platform-infrastructure administration -- but every mutating route here required
platform.manage_infra, an admin-only permission with no self-service equivalent, so no regular developer account could ever use this feature.workspace.launch(a new permission in omnibioai-auth's registry, grantable to a regular role likescientist) now satisfies the same gate;platform.manage_infrakeeps working unchanged for admin accounts.requireIdentityaccepts either a single permission name (every pre-existing call site) or an array where holding any one is sufficient.Test plan
CI=true npx react-scripts test --testPathPattern="server.test.js"-- 37 passed (35 existing + 2 new)🤖 Generated with Claude Code