Repository navigation
ci: restore CI with lint and test checks - #6
Merged
Merged
Conversation
CI was moved to .github/workflows_disabled. Restored as-is it would fail: - `pip install -e .` fails because setup.py imports Cython, which no build dependency declares, so the runtime dependencies (pyjwt, starlette, ...) were never installed and four test modules failed to import. - An unconfigured, current ruff enables rules the code was never written against (27 findings). The new .github/workflows/ci.yml installs the runtime dependencies listed in pyproject.toml, without building the Cython extensions, and runs ruff and pytest on Python 3.10-3.13 for pushes and pull requests to main. It does not publish: the tag-triggered GHCR job stays in workflows_disabled. pyproject.toml gains a [tool.ruff] block selecting E and F, and the four unused imports it reports in tests/ are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016nxi4bp7DP1ancERNUUfzj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was moved to
.github/workflows_disabled, so pushes and PRs tomainran no checks. Restoring the old file unchanged would fail, so this PR also fixes what it would have hit.Why the old workflow fails
pip install -e .errors becausesetup.pyimports Cython, which no build dependency declares. The runtime dependencies (pyjwt,starlette, …) were therefore never installed, and four test modules failed to import.What this PR adds
.github/workflows/ci.yml: on pushes and PRs tomain, installs the runtime dependencies listed inpyproject.toml, then runsruff check .andpyteston Python 3.10–3.13. It doesn't build the Cython extensions; the tests exercise the Python sources from the repository root, as they did locally.[tool.ruff]inpyproject.toml: selectsE/Fwith a 120-character line length. The four unused imports this reports intests/are removed.workflows_disabled/.Not changed: packaging. Making
pip installwork would mean declaring Cython in a[build-system]table, which compiles the extensions on every install. That is a separate decision.Verified locally: ruff passes, and all 103 tests pass on Python 3.10, 3.11, 3.12 and 3.13. The workflow's install script was replayed on a fresh Python 3.10 environment.
🤖 Generated with Claude Code
https://claude.ai/code/session_016nxi4bp7DP1ancERNUUfzj
Generated by Claude Code