Repository navigation
fix(ci): guard release manifest reconcile commit when nothing to commit - #22
Merged
Merged
Conversation
The 'Create tag + GitHub release' step in reusable-release.yml ran 'git commit' under set -e after rewriting .release-please-manifest.json with jq; when the manifest already matches the changelog head (normal after a release-PR merge), jq's rewrite produces no diff and 'git commit' fails with 'nothing to commit, working tree clean', failing the Release job after the GitHub release was already created. Only commit/push when a change is staged. Same shared-workflow fix as OneByJorah/telnoc#48.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Release workflow failure: release job exits 1 with 'nothing to commit, working tree clean'.
In
.github/workflows/reusable-release.yml, the manifest reconcile step rewrites.release-please-manifest.jsonvia jq and always runsgit commitunderset -e. When the manifest already matches the changelog head (normal after a release-PR merge), the rewrite produces no diff and the job fails after the GitHub release was already created.Fix: only commit/push when
git diff --cached --quietshows a staged change.Identical shared-workflow patch applied to telnoc, nuxora, pivona, konfiva, dirvex.