Repository navigation
refactor(designsystem): 하드코딩 색상 → HackathonTheme.colors 역할 토큰화 + 죽은 색 제거 - #32
Merged
Merged
Conversation
- core:designsystem 내 `HackathonColors`에 새로운 시맨틱 컬러 토큰 추가 (`iconUnselected`, `labelUnselected`, `onSurfaceVariant`, `outline` 등) - `CombinationCard`, `DetailScreen`, `SearchScreen`, `BottomNavBar` 등 UI 컴포넌트 전반의 하드코딩된 Hex 색상 값을 테마 프로퍼티로 변경 - `Color.kt`에서 사용하지 않는 레거시 색상 정의 및 각 파일의 미사용 임포트 제거 - `ImageUploadSection`의 `drawBehind` 블록 내에서 테마 색상을 사용할 수 있도록 변수 호이스팅 적용
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
Color(0xFF...)→ 디자인시스템 토큰화 +HackathonTheme.colors(CompositionLocal) 역할 기반 라우팅. 다크모드 도입 대비(역할은 라이트/다크 공통, 값만 테마별 교체).HackathonColors에 역할 필드 추가 → 사용처는 전부HackathonTheme.colors.X경유:iconUnselected(8B91A1) ·labelUnselected(939DA9) ·onSurfaceVariant(C0C0C0) ·outline(CCCCCC) ·textSecondary(555555) ·surfaceVariant(F7F7F7) ·primaryContainer(FFF3F3).Primary/Black은 기존colors.primary/.black재사용.drawBehind(비-Composable)는 색을 Composable 본문에서 호이스팅해 사용.PrimaryDark,TextPrimary,TextSecondary, Legacy 블록(Secondary/SecondaryLight/Purple80/PurpleGrey80/Pink80/Purple40/PurpleGrey40/Pink40— Compose 템플릿 잔재). 참조 0 확인.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
UI 변경 없음 — 토큰 값이 기존 hex와 동일해 렌더 결과 동일. 캡처 생략.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
:app:assembleDebug+lintDebug+ ktlint 1.8.0(로컬) 전부 green.onSurfaceVariant는 텍스트+구분선 혼용).HackathonColors추가 +HackathonTheme에서 스위치, 역할/사용처는 그대로.Gray700직접참조(61곳)는 본 PR 범위 밖(별개 일관성 이슈)으로 유지.