Repository navigation
fix(designsystem): Sub2_medium 폰트 패밀리 오류 수정 (FontBold → FontMedium) - #36
Merged
Merged
Conversation
- FontFamily 구성 시 실제 Pretendard 폰트 리소스(Bold, SemiBold, Medium, Regular) 연결 - Sub2_medium 스타일의 fontFamily가 FontBold로 잘못 지정되어 있던 설정을 FontMedium으로 변경 - 폰트 적용 관련 TODO 주석 제거
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
HackathonTypography.Sub2_medium의fontFamily가FontBold로 잘못 지정돼 medium 텍스트가 bold 로 렌더되던 버그를FontMedium으로 수정.*_medium(Sub1_medium·Body_medium·Caption_medium)은 모두FontMedium,Sub2_semibold은FontSemiBold사용 —Sub2_medium만 패밀리가 어긋나 있었음.Type.kt상단 stale TODO 주석 제거(이미FontFamily(Font(R.font.pretendard_*))로 적용됐는데 "시스템 기본 폰트 사용" 으로 남아 사실과 불일치).📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Sub2_medium적용 텍스트의 굵기가 bold → medium 으로 바뀝니다. 프리뷰/실기기에서 굵기 확인 권장.💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
:app:assembleDebug+:core:designsystem컴파일 + ktlint 1.8.0(로컬) green.Sub2_medium사용처에서 의도한 굵기가 medium 인지 눈으로 확인 부탁드립니다.Sub2_semibold의lineHeight = 28이 다른 Sub2(18)와 달라 보이나 확신이 없어 본 PR 범위 밖으로 유지.