Repository navigation
fix: 수동 PR 검증의 숫자 입력 정규화 - #212
Merged
Merged
Conversation
Convert string dispatch inputs with fromJSON(format(...)) while retaining numeric PR events and zero fallback. Source: https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#fromjson
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
Closes #210
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
스크린샷 bot commit 뒤 수동 재검증이 PR 번호 문자열을 reusable workflow의 number 입력으로 넘기면서 작업 시작 전에 실패했습니다. PR Validation 진입점에서 번호를 명시적으로 숫자로 변환해 네 검증 workflow에 전달합니다. 기존 PR 이벤트와 번호0의 전체 검사 경로는 유지합니다.
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
UI 변경 없음.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Node 정책 테스트300개, actionlint, git diff --check 성공. 동일 head의 실제 workflow_dispatch 실행34022399408에서 Repository Quality, ktlint, Android lint, unit, screenshot이 모두 성공했습니다. 처음 pull_request 실행은 수동 실행과 같은 PR concurrency에 의해 취소되어, 이 기록을 갱신한 후 정상 PR 이벤트 검사도 확인합니다. 기존 실패 근거는 PR207의 실행34022151411이며 제품 코드 실패와 구분했습니다.
공식 타입 변환 근거: https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#fromjson