[projmgr] Clear project setup controls before collecting compiler-specific options - #2605
Open
brondani wants to merge 2 commits into
Open
[projmgr] Clear project setup controls before collecting compiler-specific options#2605brondani wants to merge 2 commits into
brondani wants to merge 2 commits into
Conversation
Test Results 2 files 14 suites 13m 4s ⏱️ Results for commit a04bb17. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Fixes duplicated relative paths by clearing project setup controls before processing compiler-specific setups.
Changes:
- Reset collected setup controls during precedence processing.
- Add AC6 relative misc-option fixture coverage.
- Update generated reference outputs.
File summaries
| File | Summary |
|---|---|
tools/projmgr/test/data/ExternalGenerator/single/single-core.cproject.yml |
Adds an AC6 setup-level relative misc option. |
tools/projmgr/test/data/ExternalGenerator/ref/SingleCore/single-core.Debug+CM0.cbuild.yml |
Updates expected converted output. |
tools/projmgr/test/data/ExternalGenerator/ref/SingleCore/single-core.Debug+CM0.cbuild-gen.yml |
Updates expected generator output. |
tools/projmgr/test/data/ExternalGenerator/ref/SingleCore/single-core.Debug+Board.cbuild.yml |
Updates expected board output. |
tools/projmgr/src/ProjMgrWorker.cpp |
Clears stale setup controls before collection. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
brondani
marked this pull request as ready for review
September 14, 2026 11:08
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 185 185
Lines 30673 30674 +1
Branches 18056 18056
=======================================
+ Hits 22285 22286 +1
Misses 6080 6080
Partials 2308 2308
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Changes
Checklist