Skip to content

[projmgr] Clear project setup controls before collecting compiler-specific options - #2605

Open
brondani wants to merge 2 commits into
mainfrom
clear-project-setup-controls
Open

[projmgr] Clear project setup controls before collecting compiler-specific options#2605
brondani wants to merge 2 commits into
mainfrom
clear-project-setup-controls

Conversation

@brondani

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Clear previously collected project setup controls before processing matching setups.
  • Add external-generator fixture coverage for AC6 setup-level C misc options with relative paths.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Test Results

  2 files   14 suites   13m 4s ⏱️
482 tests 482 ✅ 0 💤 0 ❌
964 runs  964 ✅ 0 💤 0 ❌

Results for commit a04bb17.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Fixes duplicated relative paths by clearing project setup controls before processing compiler-specific setups.

Changes:

  • Reset collected setup controls during precedence processing.
  • Add AC6 relative misc-option fixture coverage.
  • Update generated reference outputs.
File summaries
File Summary
tools/projmgr/test/data/ExternalGenerator/single/single-core.cproject.yml Adds an AC6 setup-level relative misc option.
tools/projmgr/test/data/ExternalGenerator/ref/SingleCore/single-core.Debug+CM0.cbuild.yml Updates expected converted output.
tools/projmgr/test/data/ExternalGenerator/ref/SingleCore/single-core.Debug+CM0.cbuild-gen.yml Updates expected generator output.
tools/projmgr/test/data/ExternalGenerator/ref/SingleCore/single-core.Debug+Board.cbuild.yml Updates expected board output.
tools/projmgr/src/ProjMgrWorker.cpp Clears stale setup controls before collection.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@brondani
brondani marked this pull request as ready for review September 14, 2026 11:08
@brondani
brondani requested a review from edriouk September 14, 2026 11:08
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.65%. Comparing base (94cb0c5) to head (a04bb17).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2605   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files         185      185           
  Lines       30673    30674    +1     
  Branches    18056    18056           
=======================================
+ Hits        22285    22286    +1     
  Misses       6080     6080           
  Partials     2308     2308           
Flag Coverage Δ
projmgr-cov 87.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.44% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani brondani changed the title Clear project setup controls before collecting compiler-specific options [projmgr] Clear project setup controls before collecting compiler-specific options Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants