Conversation
Test Results 2 files 14 suites 15m 24s ⏱️ Results for commit 2e9b53f. |
There was a problem hiding this comment.
🟡 Changes recommended
The legacy --cbuildgen path must also emit ARM_DEVICE_TZ_DISABLED.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds ARM_DEVICE_TZ_DISABLED for TrustZone-disabled configurations and updates related cbuild reference outputs.
Changes:
- Adds compiler and assembler defines through the RTE target.
- Updates TrustZone-disabled and project-setup reference fixtures.
File summaries
| File | Description |
|---|---|
tools/projmgr/test/data/TestSolution/DeviceAttributes/ref/trustzone.Debug+tz-disabled.cbuild.yml |
Updates TrustZone reference output. |
tools/projmgr/test/data/TestProjectSetup/ref/setup-test.Build_GCC+TEST_TARGET.cbuild.yml |
Updates GCC reference output. |
tools/projmgr/test/data/TestProjectSetup/ref/setup-test.AbsolutePath+TEST_TARGET.cbuild.yml |
Updates absolute-path reference output. |
tools/projmgr/src/ProjMgrWorker.cpp |
Adds the TrustZone-disabled define; legacy --cbuildgen output still omits it. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 185 185
Lines 30673 30675 +2
Branches 18056 18058 +2
=======================================
+ Hits 22285 22287 +2
Misses 6080 6080
Partials 2308 2308
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ARM_DEVICE_TZ_DISABLED when trustzone is disabledARM_DEVICE_TZ_DISABLED when trustzone is disabled
Fixes
ARM_DEVICE_TZ_DISABLED[Question] impacts of trustzone values in .cproject.yml project files cmsis-toolbox#642 (comment)Changes
ARM_DEVICE_TZ_DISABLEDcompiler and assembler define when a device is configured withtrustzone: off.Checklist