Skip to content

[projmgr] Define ARM_DEVICE_TZ_DISABLED when trustzone is disabled - #2606

Open
brondani wants to merge 1 commit into
mainfrom
define-arm-device-disabled
Open

brondani wants to merge 1 commit into
mainfrom
define-arm-device-disabled

Conversation

@brondani

@brondani brondani commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Add the ARM_DEVICE_TZ_DISABLED compiler and assembler define when a device is configured with trustzone: off.
  • Update project-manager cbuild reference outputs for TrustZone-disabled configurations.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

Copy link
Copy Markdown

Test Results

  2 files   14 suites   15m 24s ⏱️
482 tests 482 ✅ 0 💤 0 ❌
964 runs  964 ✅ 0 💤 0 ❌

Results for commit 2e9b53f.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The legacy --cbuildgen path must also emit ARM_DEVICE_TZ_DISABLED.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds ARM_DEVICE_TZ_DISABLED for TrustZone-disabled configurations and updates related cbuild reference outputs.

Changes:

  • Adds compiler and assembler defines through the RTE target.
  • Updates TrustZone-disabled and project-setup reference fixtures.
File summaries
File Description
tools/projmgr/test/data/TestSolution/DeviceAttributes/ref/trustzone.Debug+tz-disabled.cbuild.yml Updates TrustZone reference output.
tools/projmgr/test/data/TestProjectSetup/ref/setup-test.Build_GCC+TEST_TARGET.cbuild.yml Updates GCC reference output.
tools/projmgr/test/data/TestProjectSetup/ref/setup-test.AbsolutePath+TEST_TARGET.cbuild.yml Updates absolute-path reference output.
tools/projmgr/src/ProjMgrWorker.cpp Adds the TrustZone-disabled define; legacy --cbuildgen output still omits it.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/projmgr/src/ProjMgrWorker.cpp
@brondani
brondani marked this pull request as ready for review September 14, 2026 13:48
@brondani
brondani requested a review from edriouk September 14, 2026 13:48
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.65%. Comparing base (94cb0c5) to head (2e9b53f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2606   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files         185      185           
  Lines       30673    30675    +2     
  Branches    18056    18058    +2     
=======================================
+ Hits        22285    22287    +2     
  Misses       6080     6080           
  Partials     2308     2308           
Flag Coverage Δ
projmgr-cov 87.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.44% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brondani brondani changed the title Define ARM_DEVICE_TZ_DISABLED when trustzone is disabled [projmgr] Define ARM_DEVICE_TZ_DISABLED when trustzone is disabled Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants