Skip to content

feat(audio): add optional playback echo cancellation #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HKLHaoBin wants to merge 7 commits into
base: beta
Choose a base branch
from
Open

feat(audio): add optional playback echo cancellation #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1dd08ac
feat(audio): add optional playback echo cancellation (#1223)
HKLHaoBin Oct 17, 2026
5519c6e
fix(ci): keep recorder harness on cpal 0.18
HKLHaoBin Oct 17, 2026
986526f
chore(audio): instrument issue 1223 stream failures
HKLHaoBin Oct 20, 2026
8005a17
fix(audio): keep capture running after recoverable xruns
HKLHaoBin Oct 20, 2026
9d34723
fix(ci): allow manual Intel macOS runner fallback
HKLHaoBin Oct 20, 2026
2b274ea
Merge upstream beta and preserve issue 1223 diagnostics
HKLHaoBin Oct 21, 2026
07e3bc6
fix(audio): adapt native cue to cpal 0.18
HKLHaoBin Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ on:
type: choice
options: [all, macos]
default: all
macos_runner:
description: macOS runner (Intel fallback when hosted ARM capacity is unavailable)
type: choice
options: [macos-latest, macos-15-intel]
default: macos-latest

# Cancel old runs when the same PR is pushed repeatedly; workflow_dispatch is isolated by run_id.
concurrency:
Expand Down Expand Up @@ -399,7 +404,8 @@ jobs:
fail-fast: false
matrix:
include: ${{ fromJSON(github.event_name == 'workflow_dispatch' && inputs.platform == 'macos' && '[{"os":"macos-latest","label":"macOS","preflight":false}]' || '[{"os":"macos-latest","label":"macOS","preflight":false},{"os":"windows-latest","label":"Windows","preflight":true}]') }}
runs-on: ${{ matrix.os }}
# Dispatch-only fallback; push/PR runs keep the default matrix and all test gates.
runs-on: ${{ matrix.label == 'macOS' && github.event_name == 'workflow_dispatch' && inputs.macos_runner || matrix.os }}
timeout-minutes: 60
env:
# The shared Core and full Tauri test binary compile together; limit concurrency
Expand Down Expand Up @@ -601,7 +607,7 @@ jobs:
# with stable, which is a superset of the MSRV promise).
if: needs.changes.outputs.msrv != 'false' && needs.changes.outputs.msrv_needed == 'true'
name: macOS Rust 1.99 MSRV
runs-on: macos-latest
runs-on: ${{ github.event_name == 'workflow_dispatch' && inputs.macos_runner || 'macos-latest' }}
timeout-minutes: 60
env:
CARGO_BUILD_JOBS: 2
Expand Down
159 changes: 159 additions & 0 deletions docs/issue-1223-aec-feasibility.md
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions openless-all/app/crates/openless-core/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5288,6 +5288,7 @@ impl OpenLessBackend {
pre_roll_ms: 500,
audio_processing: crate::audio::AudioProcessingConfig {
enhancement_enabled: preferences.audio_enhancement_enabled,
echo_cancellation_enabled: preferences.echo_cancellation_enabled,
},
};
match self.deps.dictation_engine.arm_audio_capture(request) {
Expand Down
Loading
Loading