chore: update to PHP 8.5 - #30
Merged
Merged
Conversation
PHP 8.5 surfaces implicit-nullable deprecations in Mockery generated mocks. These ran via the @tests post-update-cmd during composer require, failing the job before the guarded test step. Install deps with --no-scripts so only the allowed-to-fail test step runs phpunit.
johanib
reviewed
Sep 8, 2026
johanib
reviewed
Sep 8, 2026
johanib
requested changes
Sep 8, 2026
Contributor
Author
|
Checked the upcoming Symfony workflow against composer.json: this bundle now requires PHP >=8.2, <9.0-dev, so PHP 7.4 is no longer supported. Keeping that job on PHP 8.5 only is intentional. Added a CHANGELOG entry for the Composer platform bump to 8.5 and the code checks, code coverage, and upcoming Symfony workflow PHP version updates. There is no UPGRADING.md in this repo. |
Composer now targets PHP 8.5 and the PR updates the CI workflows to use the same version. Add a changelog entry documenting those changes while keeping the upcoming Symfony job on PHP 8.5 because composer.json supports PHP >=8.2 only.
kayjoosten
force-pushed
the
chore/php85-composer-update
branch
from
September 8, 2026 21:31
03677c1 to
f4bda07
Compare
|
Identified SF 8 breakage: #31 Out of scope for this PR. |
johanib
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Composer-only update to PHP 8.5 (config.platform.php bump; require.php already permitted 8.5). Bumps hardcoded php-version in 3 CI workflow files. Verified full composer tests gate (docheader/phpcs/phpcpd/phpunit/phpmd) locally on PHP 8.5. Confirmed sebastian/phpcpd does not pull in the irstea/phpcpd-shim dead-VCS-host chain seen in a sibling repo.