feature/build.openconext.org - #737
Open
baszoetekouw wants to merge 4 commits into
Open
baszoetekouw wants to merge 4 commits into
baszoetekouw wants to merge 4 commits into
Conversation
baszoetekouw
commented
Sep 6, 2026
Member
- Deploy apache config
- cert handling of build.opeconenxt.org
- Index.html is static
- Disable access to vagrant boxes
Member
Author
crosmuller
reviewed
Sep 7, 2026
| ## acme | ||
| ######################################################### | ||
| - name: "Install ACME scripts" | ||
| ansible.builtin.include_role: |
Contributor
There was a problem hiding this comment.
Is het de bedoeling om later een acme role te maken? Die gedeployed kan op haproxy en apache?
crosmuller
reviewed
Sep 7, 2026
| failed_when: 'acme_issue.rc != 0 and acme_issue.rc != 2' | ||
|
|
||
| - name: "Deploy cert to Apache" | ||
| ansible.builtin.command: |
Contributor
There was a problem hiding this comment.
wordt het certificate met deze opties steeds vernieuwd bij een deploy? Of alleen indien nodig?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.