Fix iCloud Passwords YubiKey input handling - #540
Merged
Merged
Conversation
Why is this change needed? Prior to this change, Safari and iCloud Passwords treated the browser-visible `otp` field as a one-time-password input and intercepted the YubiKey-generated Enter event, preventing the RA form from submitting. How does it address the issue? This change renames the browser-visible field to `yubikeyInput` across the RA form and command flow while preserving the downstream `otp.value` API payload. Regression tests cover rendered field metadata, command mapping, and API serialization. Issue: #486 Pull request: #540
kayjoosten
force-pushed
the
feature/issue-486-icloud-yubikey-otp-fix
branch
from
September 9, 2026 10:46
da41faf to
72f2579
Compare
johanib
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otprequest payload contract.Fixes #486
Test plan
XDEBUG_MODE=off vendor/bin/phpunit --configuration=ci/qa/phpunit.xml src/Surfnet/StepupRa/RaBundle/Tests/Form/Type/VerifyYubikeyPublicIdTypeTest.php src/Surfnet/StepupRa/RaBundle/Tests/Service/YubikeyServiceTest.phpCOMPOSER_MEMORY_LIMIT=1G composer check-cireaches all QA stages; local PHPUnit exits with the existing no-coverage-driver warning under PHP 8.5.