Skip to content

[UI] Enable strict checking for service contracts and route handler - #4047

Open
PunugupatiSaikumar wants to merge 1 commit into
OpenEMS:developfrom
PunugupatiSaikumar:feature/ui-service-contract-typescript-strict
Open

PunugupatiSaikumar wants to merge 1 commit into
OpenEMS:developfrom
PunugupatiSaikumar:feature/ui-service-contract-typescript-strict

Conversation

@PunugupatiSaikumar

Copy link
Copy Markdown
Contributor

Changes

  • Enable strict checking for AbstractService and GlobalRouteChangeHandler.
  • Add explicit service return types.
  • Match DummyService.toast to the Promise contract without changing its throwing behavior.
  • Type nullable route snapshots and metadata using Angular types.

No runtime logic changes or new test files.

Related to #3995

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4047      +/-   ##
=============================================
- Coverage      55.53%   55.45%   -0.07%     
- Complexity     19904    19907       +3     
=============================================
  Files           3916     3931      +15     
  Lines         180171   180759     +588     
  Branches       15034    15077      +43     
=============================================
+ Hits          100037   100221     +184     
- Misses         76150    76564     +414     
+ Partials        3984     3974      -10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant