Repository navigation
Equilibrium - BUGFIX - Support original and rho grids for inverse equilibria - #523
Merged
Merged
Conversation
…ilibria Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matt-pharr
approved these changes
Oct 13, 2026
matt-pharr
left a comment
Collaborator
There was a problem hiding this comment.
This looks fine, I will merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
grid_type = "original"and"rho"errored before for inverse equilibria (harness @ b182bbf)Inverse equilibria (CHEASE, LAR) now accept
grid_type = "original"(the input file's own ψ nodes) and"rho"(uniform in √ψ).Regression report
regress --cases solovev_n1 --refs bfc60610e,b182bbf68(develop vs this head; julia 1.11.7, pinned manifest, 2 threads). No harness case uses an inverse equilibrium on these grids.Notes for reviewers
originalsetmpsibut never built the ψ grid, so the run stopped with an undefined-variable error. It now uses the input's own ψ nodes, without the axis node if the file has one (a ψ = 0 surface has no geometry). psilow and mpsi are ignored; psihigh still sets psilim, as in Fortran. No minimum node spacing is applied.rhowas rejected as "Unsupported grid_type". It is uniform in √ψ from psilow to psihigh: ψᵢ = (√psilow + (√psihigh − √psilow)·i/mpsi)², i = 0…mpsi. Fortran'srhoignores psilow; here it honours psilow like the other grids.test/runtests_equil.jl, on the CHEASE test fileINP1_binary: the original grid equals the file's nodes off the axis, the rho grid runs from psilow to psihigh, and every spline is finite for both.runtests_equil.jl: 299/299 pass.equilibrium_solver; whichever lands second may need a small rebase.🤖 Generated with Claude Code