Repository navigation
Tests: allow 60 ms of slack in the audio catch-up checks - #5
Merged
Merged
Conversation
- The checks allowed 30 ms above the target, which a busy CI runner can exceed - Use kSlackMs = 60 ms, the resync threshold in host.cpp - A queue still holding the 400 ms stall stays far above the bound, so the test still catches a regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The audio catch-up checks in
tests/test_audio.cppallowed the sound queue to sit 30 ms above the target. The controller inruntime/audio/host.cppallows up to 60 ms (kResyncMs) before it drops samples. On shared CI runners the queue settles 32–45 ms above target, so the checks failed on otherwise good code. That failure stopped the Package jobs for thev1.0.2tag, so no release draft was made.The checks now use a named
kSlackMs = 60.0, matching the controller's limit. They still catch the bug they were written for: a queue still holding the 400 ms stall is far above that bound.Only the test file changes. The runtime is unchanged.
How it was tested
ctestsuite has not been run for this change, and CI has not run it yet.Checklist
python3 tools/check_game_data.pypasses).// SPDX-License-Identifier: GPL-3.0-or-later; ported Dolphin code says so.ctestpasses.