Skip to content

Tests: allow 60 ms of slack in the audio catch-up checks - #5

Merged
OfficiallySp merged 1 commit into
mainfrom
fix-audio-test
Nov 3, 2026
Merged

OfficiallySp merged 1 commit into
mainfrom
fix-audio-test

Conversation

@OfficiallySp

Copy link
Copy Markdown
Member

What this changes

The audio catch-up checks in tests/test_audio.cpp allowed the sound queue to sit 30 ms above the target. The controller in runtime/audio/host.cpp allows up to 60 ms (kResyncMs) before it drops samples. On shared CI runners the queue settles 32–45 ms above target, so the checks failed on otherwise good code. That failure stopped the Package jobs for the v1.0.2 tag, so no release draft was made.

The checks now use a named kSlackMs = 60.0, matching the controller's limit. They still catch the bug they were written for: a queue still holding the 400 ms stall is far above that bound.

Only the test file changes. The runtime is unchanged.

How it was tested

  • The audio test passed 5 runs in a row locally.
  • The full ctest suite has not been run for this change, and CI has not run it yet.

Checklist

  • No game code, data or assets (python3 tools/check_game_data.py passes).
  • New files start with // SPDX-License-Identifier: GPL-3.0-or-later; ported Dolphin code says so.
  • ctest passes.
  • CHANGELOG.md has an entry if players will notice the change.

- The checks allowed 30 ms above the target, which a busy CI runner can exceed
- Use kSlackMs = 60 ms, the resync threshold in host.cpp
- A queue still holding the 400 ms stall stays far above the bound, so the test still catches a regression
@OfficiallySp
OfficiallySp merged commit 55c499f into main Nov 3, 2026
6 checks passed
@OfficiallySp
OfficiallySp deleted the fix-audio-test branch November 3, 2026 10:37
@OfficiallySp
OfficiallySp restored the fix-audio-test branch November 3, 2026 10:38
@OfficiallySp
OfficiallySp deleted the fix-audio-test branch November 3, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant