Repository navigation
Conversation
Contributor
Author
|
@coderabbitai review |
Contributor
Author
|
Codex source re-review found a delivery race: newer input could arrive while appendSpeech waited for the subprocess write lock. Added a failing real-child-protocol regression, then moved the final generation check inside the lock immediately before the write. Superseded speech is not sent; saved work is unchanged. Now 53 relay/router tests pass; Ruff and targeted Pyright pass. No live provider or deployment. Transcript boundaries and the V3 browser interruption signal remain separate follow-ups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on the existing Voice draft #5180. Companion App PR: enyst/insider#4. Bead
smolpaws-vstale.No API schema, Codex pin, tool permissions, approval handling or run-admission changes. Steering is a separate follow-up.
Verification
52 relay/router tests, 1 existing live-socket voice route test, Ruff, targeted Pyright, and diff checks pass. New regressions failed before implementation. Protocol fixtures use a real subprocess, not a live provider. No microphone, login, paid calls or deployment.
Evidence and protocol limits. The pinned protocol cannot revoke queued speech or identify its input; browser local suppression remains necessary.