Bump wfb-ng submodule to upstream master (3504a38) - #122
Open
mengelh wants to merge 1 commit into
Open
Conversation
Previous pin (0da5279, 2025-08-05) was about a year and 56 commits behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4 constructor signature and the public counters WfbngLink.cpp reads (count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost, count_p_bad, count_p_override, count_p_outgoing) are unchanged between the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional PacketLossListener with no-op-by-default virtuals), not a breaking API change. Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no regressions in video/MAVLink reception. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab) |
PR Summary by QodoUpdate wfb-ng submodule to upstream commit 3504a38
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous pin (0da5279, 2025-08-05) was about a year and 56 commits
behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4
constructor signature and the public counters WfbngLink.cpp reads
(count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost,
count_p_bad, count_p_override, count_p_outgoing) are unchanged between
the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup
via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional
PacketLossListener with no-op-by-default virtuals), not a breaking API
change.
Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no
regressions in video/MAVLink reception.
🤖 Generated with Claude Code