Skip to content

Bump wfb-ng submodule to upstream master (3504a38) - #122

Open
mengelh wants to merge 1 commit into
OpenIPC:masterfrom
mengelh:wfb-ng-submodule-bump
Open

Bump wfb-ng submodule to upstream master (3504a38)#122
mengelh wants to merge 1 commit into
OpenIPC:masterfrom
mengelh:wfb-ng-submodule-bump

Conversation

@mengelh

@mengelh mengelh commented Sep 9, 2026

Copy link
Copy Markdown

Previous pin (0da5279, 2025-08-05) was about a year and 56 commits
behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4
constructor signature and the public counters WfbngLink.cpp reads
(count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost,
count_p_bad, count_p_override, count_p_outgoing) are unchanged between
the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup
via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional
PacketLossListener with no-op-by-default virtuals), not a breaking API
change.

Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no
regressions in video/MAVLink reception.

🤖 Generated with Claude Code

Previous pin (0da5279, 2025-08-05) was about a year and 56 commits
behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4
constructor signature and the public counters WfbngLink.cpp reads
(count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost,
count_p_bad, count_p_override, count_p_outgoing) are unchanged between
the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup
via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional
PacketLossListener with no-op-by-default virtuals), not a breaking API
change.

Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no
regressions in video/MAVLink reception.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Update wfb-ng submodule to upstream commit 3504a38

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Advances bundled wfb-ng from 0da5279 to upstream commit 3504a38.
• Preserves existing aggregator constructors and telemetry counter integration.
• Includes on-device RTL8812AU validation for video and MAVLink reception.
Diagram

graph TD
  UP["wfb-ng 3504a38"] -->|compiled into| LIB["Native wfb-ng"] -->|Aggregator API| LINK["WfbngLink"] -->|video and MAVLink| UDP["UDP Receivers"]
Loading
High-Level Assessment

Pinning the verified upstream commit is the appropriate approach: it preserves reproducible builds while incorporating the desired upstream fixes. Dynamically tracking master would reduce maintenance but make builds non-reproducible, while vendoring the source would duplicate upstream history and complicate future updates.

Files changed (1) +1 / -1

Other (1) +1 / -1
wfb-ngAdvance the wfb-ng submodule by 56 upstream commits +1/-1

Advance the wfb-ng submodule by 56 upstream commits

• Moves the wfb-ng gitlink from 0da5279 to 3504a38. The newer revision introduces internal receiver improvements while retaining the AggregatorUDPv4 constructor and public counters consumed by WfbngLink.

app/wfbngrtl8812/src/main/cpp/wfb-ng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant