Repository navigation
release: Telegram gets the binaries of a new version as files, no text announcement (#40) - #41
Merged
Merged
Conversation
…t announcement (#40) The OpenIPC Telegram dev channel is for build files (archive, test downloads), not text posts: the sendMessage announcement with a CHANGELOG excerpt (#38) is replaced by one sendMediaGroup post of the four cerberus-<arch> binaries as documents, with a short caption on the last one: version, commit, time, the latest link. Still only for a new version (not a re-publication of the same one); missing secrets or a failed upload are a warning. READMEs: the binaries of every new version are also posted to the Telegram channel. Tested with curl stubbed (nothing sent): one sendMediaGroup call with the four binaries attached and a valid media JSON, the caption on the last one. Closes #40
PR Summary by QodoPost new-release binaries to Telegram instead of text announcements
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can see how risky a PR is at a glance with blast radius labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40. @keyldev: this replaces the text post of #38 before it ever runs here (0.3.2 would have been the first).
sendMessagepost with aCHANGELOG.mdexcerpt went out from OpenIPC/vectis for 1.9.0 and was not wanted. The release job'sTelegramstep now sends the fourcerberus-<arch>binaries as files in onesendMediaGrouppost, with a short caption on the last one:Cerberus <version> for Linux, commit, time,releases/latest.announce, not a re-publication of the same version); missing secrets or a failed upload are a warning, the release stays.Tested in
compot/crosswithcurlstubbed (nothing sent): onesendMediaGroupcall with the four binaries attached and a validmediaJSON, the caption on the last document. Workflow and docs only: no version bump.