Repository navigation
ci: the version check runs in its own version.yml (#44) - #45
Merged
Merged
Conversation
…longer re-runs the whole CI (#44)
PR Summary by QodoRun the PR version check in a separate workflow
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can move or hide resolved findings to focus on what still needs action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
ci.ymllistened tolabeled/unlabeledbecause itsversionjob reads theno-releaselabel, so adding or removing any label on a pull request re-ran the whole CI (shellcheck, the suite on both mbedTLS generations, the four release builds)..github/workflows/version.yml: the version check alone, onpull_requestincludinglabeled/unlabeled,check-version.sh HEAD^1withNO_RELEASEfrom theno-releaselabel, its own concurrency group per pull request.ci.yml: theversionjob and the label event types are gone; nothing needed that job; lint, test, build and release are unchanged.check-version.sh:ci.ymlstill counts as build;version.ymlis CI. Comments updated.version.yml.CI only: no version bump,
no-releaselabel.Test report (local):
-S styleoncheck-version.sh: clean.ci.ymljobs: build, lint, release, test;version.yml: version.check-version.shon throwaway commits, exit code without / withNO_RELEASE=true:version.ymlonly 0/0,ci.ymlonly 1/0,src/only 1/0, README only 0/0.@keyldev, for visibility: a CI-only follow-up to #43.