Repository navigation
XM: optional WLANDEV, for a board whose only network is Wi-Fi - #57
Merged
Merged
Conversation
OpenIPC brings a radio up only when the U-Boot env names its /etc/wireless profile in wlandev (S40network). The env this script writes has none, so a Wi-Fi-only board moved over -- the GK7201V200 G3-WQ-G (000929QB, an ATBM6012B-X, OpenIPC/firmware#2729) -- would boot with no driver loaded and no way onto the network. WLANDEV=<profile> adds wlandev=<profile> to the env, as SENSOR adds sensor=. The network itself, wlanssid and wlanpass, is the owner's and is never written here. OpenIPC's fw_printenv finds this env at 0x30000 by its CRC, scanning the partitions in order, so S40network sees it on the fixed-slot and the split layout alike. Unset, the env is byte-identical to before (gk7201v200, 33 variables); set to atbm603x-generic-usb, it gains that one line.
PR Summary by QodoAllow XM conversions to configure a Wi-Fi radio profile
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenIPC brings a radio up only when the U-Boot env names its
/etc/wireless profile in wlandev (S40network). The env this script
writes has none, so a Wi-Fi-only board moved over -- the GK7201V200
G3-WQ-G (000929QB, an ATBM6012B-X, OpenIPC/firmware#2729) -- would
boot with no driver loaded and no way onto the network.
WLANDEV= adds wlandev= to the env, as SENSOR adds
sensor=. The network itself, wlanssid and wlanpass, is the owner's and
is never written here. OpenIPC's fw_printenv finds this env at 0x30000
by its CRC, scanning the partitions in order, so S40network sees it on
the fixed-slot and the split layout alike.
Unset, the env is byte-identical to before (gk7201v200, 33 variables);
set to atbm603x-generic-usb, it gains that one line.