Skip to content

rda5995-openipc: build the firmware into the module #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimerr merged 1 commit into from
Oct 21, 2026
Merged

rda5995-openipc: build the firmware into the module #2653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion general/package/rda5995-openipc/rda5995-openipc.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
################################################################################

RDA5995_OPENIPC_VERSION = 593c3184ae3f84c563b1704f6ad24879f122634b
RDA5995_OPENIPC_VERSION = 06fd4b61252788bc46a66c88fd2773493ab5dd2a

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Camera firmware change lacks testing 📘 Rule violation ≡ Correctness

The package version change selects firmware-embedding driver sources without testing firmware
download on a real camera. The PR states that no camera with the affected chip was available and
that the emulator has no RDA device, so the changed camera behavior remains unverified.
Agent Prompt 
## Issue description
The package now selects a commit that changes the firmware-loading behavior, but the PR provides no real-camera evidence and explicitly says firmware download is untested.

## Fix Focus Areas
- general/package/rda5995-openipc/rda5995-openipc.mk[7-7]

## Recommended Fix
Test the updated module on a camera containing an RDA5995, capture firmware-download and driver initialization output, and add the affected board, symptom, and before/after evidence to the PR description.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

RDA5995_OPENIPC_SITE = $(call github,openipc,rda-wlan,$(RDA5995_OPENIPC_VERSION))

# Rdamicro's permission notice heads every source file; the module
Expand Down
Loading