Repository navigation
anyka: v4l-utils on every AK39 image - #2654
Conversation
The Anyka capture path and the EV200 encoder are V4L2 devices, and the images had no tool to list or set their formats and controls. Enabled as v83x and dm36x do. AV130 stays out: at 4608KB of 5120 it does not fit v4l-utils and libstdc++.
84db305 to
6a041bd
Compare
PR Summary by QodoAdd V4L2 utilities to seven Anyka AK39 images
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Code Review by Qodo
1. Camera images lack hardware testing
|
| BR2_PACKAGE_LIBV4L=y | ||
| BR2_PACKAGE_LIBV4L_UTILS=y |
There was a problem hiding this comment.
1. Camera images lack hardware testing 📘 Rule violation ☼ Reliability
ak3918ev200_lite_defconfig enables both V4L2 packages. The PR says no camera was available and only QEMU was booted, so the affected images lack real-camera boot or streaming evidence.
Agent Prompt
## Issue description
The defconfig changes alter firmware images that can run on cameras, but the PR provides only QEMU evidence and explicitly states that no camera was tested.
## Fix Focus Areas
- br-ext-chip-anyka/configs/ak3918ev200_lite_defconfig[30-31]
## Recommended Fix
Boot an affected AK39 image on real camera hardware and provide before/after evidence for the relevant behavior, such as successful boot, V4L2 device discovery, format inspection, or streaming.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Problem
The Anyka capture path (
ak_camera, the open ISP host) and the EV200 encoder (ak-venc) are V4L2 devices, and the AK39 images ship no tool to list or set their formats and controls.Changes
BR2_PACKAGE_LIBV4L=yandBR2_PACKAGE_LIBV4L_UTILS=yin every AK39 defconfig, asv83x_lite,v83x_ultimateanddm36x_litealready do.ak3918av130_litestays out: it is at 4608 KB of 5120, and v4l-utils withlibstdc++adds about 1190 KB.Hardware tested on
No camera. Built locally and booted in the qemu-hisilicon emulator (
ak3918ev200machine), which has no sensor or 8290 encoder model, so there is no/dev/video0there.Evidence
ak3918ev200_lite, built locally with #2653's rda5995 pin:Installed:
v4l2-ctl,media-ctl,v4l2-compliance,v4l2-sysfs-path,cec-*,ir-ctl,ir-keytable,rds-ctl,cx18-ctl,ivtv-ctl,decode_tm6000, the libv4l libraries andlibstdc++.ci-matrix.py --self-testpasses.Scope
general/package/all-patches/linux/(those go to OpenIPC/linux)general/overlay/or in a sharedload_<vendor>script hardcodes a value specific to my boardLD_PRELOAD, and no binaries that cannot be rebuilt from source