Repository navigation
ci: measure ipcinfo growth by its sections, not its page-rounded file size - #251
Merged
Merged
Conversation
… size The budget compared stat -c %s of ipcinfo before and after. That file is page-quantised: the RW segment's file offset has to equal its address modulo 4096, so it jumps a whole page whenever the code in front of it crosses a boundary. On master the code segment ends exactly where the data segment begins (0xae68 both), so the slack is zero bytes. A change adding 12 bytes of code (#249) and one adding 24 (#250) each "grew" ipcinfo by 4096 and failed the 1024-byte budget. Measure text + data + bss from size(1) instead: what the camera loads, growing by the bytes the change adds. With the CI toolchain those two PRs measure +12 and +24.
PR Summary by QodoMeasure ipcinfo size-budget growth by sections
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can see how risky a PR is at a glance with blast radius labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ipcinfosize budget inpr-build-check.ymlcompared the file size ofipcinfobefore and after a PR. That number is page-quantised, and on current master it has no slack at all, so every PR that adds a single byte of code toipcinfofails it.Why
5d678de, CI's toolchain), the code segment ends at file offset0xae68, and the data segment starts at exactly0xae68.Reproduced with
toolchain.hisilicon-hi3516cv100.tgz, the same configure as the job:Change
Measure
text + data + bssfromsize(1)(itsdeccolumn) instead: what the camera actually loads, which grows by the bytes a change adds. The budget and the base-commit comparison are unchanged.