Repository navigation
release: Telegram gets the binaries of a new version as files, no text announcement (#58) - #59
Merged
Merged
Conversation
…t announcement (#58) The OpenIPC Telegram dev channel is for build files (archive, test downloads), not text posts: the sendMessage announcement with a CHANGELOG excerpt (as for 1.9.0) is replaced by one sendMediaGroup post of the release binaries (vectis-linux-*) as documents, with a short caption on the last one: version, commit, time, the latest link. Still only for a new version; missing secrets or a failed upload are a warning. READMEs: the binaries of every new version are also posted to the Telegram channel. Tested with curl stubbed (nothing sent): without secrets a warning and exit 0; with them one sendMediaGroup call with both binaries attached and a valid media JSON (checked with jq), the caption on the last one. Closes #58
PR Summary by QodoPost new-version binaries to Telegram as one media group
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can see how risky a PR is at a glance with blast radius labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58.
Telegramstep no longer sends a text post (sendMessagewith aCHANGELOG.mdexcerpt, as it did for 1.9.0). For a new version it sends the release binaries as files —vectis-linux-x86_64,vectis-linux-mipsel(dist/vectis-linux-*) — in onesendMediaGrouppost, with a short caption on the last one:Vectis <version> for Linux, commit, time,releases/latest. The channel is for build files (archive, test downloads), as OpenIPC/vtesse, OpenIPC/decoder and OpenIPC/camex post their APKs.Tested in
compot/crosswithcurlstubbed (nothing sent): without secrets a warning and exit 0; with them onesendMediaGroupcall with both binaries attached (f0,f1) and a validmediaJSON (checked withjq), the caption on the last document. Workflow and docs only: no version bump, so merging posts nothing.