Repository navigation
release: no SHA256SUMS, no checksum step in the docs (#60) - #61
Conversation
Users need not check the downloaded binaries against checksums: the release job no longer merges the per-build checksums into a published SHA256SUMS, and the release notes drop the "Check:" line. READMEs: the Quick start and the permanent-links section download and chmod/install only, and SHA256SUMS is gone from the links table. Unchanged, internal to CI: ci/build-static.sh and ci/build-mipsel.sh still write a SHA256SUMS into their own artifact, and the release job checks it when it takes the binaries over (so this needs no version bump); the pinned checksum of the mipsel toolchain stays. Closes #60
PR Summary by QodoPublish releases without SHA256SUMS
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
1. Changelog promises a missing release file
|
|
Qodo finding (failed downloads can install an old binary): fixed in e935e72 — in all three READMEs the Quick start and the permanent-links example run |
|
/review |
As in OpenIPC/vectis#61: a failed curl must not leave chmod working on a file from an earlier attempt. Refs #48
| for a in vectis-x86_64-static vectis-mipsel-static; do | ||
| (cd "artifacts/$a" && sha256sum -c SHA256SUMS) | ||
| cp artifacts/$a/vectis-linux-* dist/ | ||
| cat "artifacts/$a/SHA256SUMS" >> dist/SHA256SUMS |
There was a problem hiding this comment.
1. Changelog promises a missing release file 🐞 Bug ≡ Correctness
The release job no longer copies SHA256SUMS into dist, but the 1.9.0 changelog still says the release has a checksum file covering both binaries. Because PROGRAM_VERSION remains 1.9.0 and the job replaces the only release with dist/*, that statement describes the current release but points readers to an asset it no longer contains.
Agent Prompt
## Issue description
The current 1.9.0 changelog says the release includes a checksum file, but the release job no longer publishes one.
## Fix Focus Areas
- CHANGELOG.md[18-21]
## Recommended Fix
Update the current-version release entry to describe the two published binaries without promising a `SHA256SUMS` asset.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit e935e72 |
|
Qodo: changelog promises a missing release file — not adopted: the 1.8.0 section records what that version shipped ( |
For finding 1, that distinction is valid: if the |
Closes #60.
build.yml, release job: the per-build checksums are no longer merged into a publishedSHA256SUMS; the release has the two binaries only. The notes drop the "Check:sha256sum -c SHA256SUMS" line.install/chmod, no checksum step;SHA256SUMSis gone from the links table and the text.ci/build-static.shandci/build-mipsel.shstill write aSHA256SUMSinto their own artifact, and the release job checks it when it takes the binaries over between jobs (ci/is not touched, so no version bump); the pinned checksum of the mipsel toolchain stays.Workflow and docs only.