Repository navigation
ci: run the version check in its own workflow (#66) - #67
Merged
Merged
Conversation
version.yml runs .github/check-version.sh HEAD^1 on pull requests and is the only workflow that listens to labeled/unlabeled, so adding or removing a label no longer re-runs every build. build.yml goes back to the usual pull request events. The README (three languages) now says that the build workflow counts as build and names the no-release label.
PR Summary by QodoRun pull-request version checks in a separate workflow
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can move or hide resolved findings to focus on what still needs action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66.
.github/workflows/version.yml(new): runs.github/check-version.sh HEAD^1on pull requests withNO_RELEASEfrom theno-releaselabel. It is the only workflow that listens tolabeled/unlabeled, so a label change re-runs this check, not every build. Same layout as OpenIPC/camex.build.yml: the version job and the label event types are gone; the release job (head-only publish) is unchanged.check-version.sh: comment only (where CI runs it;version.ymlis CI, not build).no-releaselabel covers a change that leaves the release files as they are.Checked locally: shellcheck v0.10.0 clean; both workflows parse as YAML;
check-version.shagainst master on this branch: fails withoutNO_RELEASE(build.yml changed, version still 1.9.0), passes with it.CI only: no version bump, hence the
no-releaselabel.