Repository navigation
Catalogue: the hi3516ev200 family and hi3516cv300 on the split NOR layout - #491
Merged
Merged
Conversation
hi3516ev300's lite and ultimate builds now ship only the split NOR
package (OpenIPC/firmware split/hi3516ev300): its kernel fills the 2 MiB
slot, so no fixed-slot package can ship beside a split one. neo keeps
its own fixed-slot build.
nor_split, without nor_split_only: SplitOnlyEdition then takes the split
package for every edition that has one and no plain package, and keeps
neo on fixed slots; nor_split_only would have dropped neo from the
installer. That needs the stale plain openipc.hi3516ev300-nor-
{lite,ultimate}.tgz gone from the release once the split packages
publish; until then the site keeps offering them as fixed slots, as
today.
Tests: the fixture release index is moved to that state (the two
-split packages in, the plain lite/ultimate out; neo kept), and the
golden regenerated: hi3516ev300 still offers nor lite, ultimate, neo and
nand ultimate, lite and ultimate as split images. The two firmware
tests and the wizard test that used hi3516ev300 as a fixed-slot NOR SoC
use hi3516ev200 (same bootloaders and NAND layout, fixed slots kept).
go test ./... passes.
…dv200 on the split NOR layout They ship -split packages since OpenIPC/firmware#2645, #2655 and #2656 (hi3518ev300 split-only, like hi3516ev300); nor_split lets each edition use its split package where no plain one is published, and keeps the fixed-slot one where it is. go test ./... (uncached) passes.
PR Summary by QodoCatalogue split NOR packages for six HiSilicon SoCs
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
From review: their bootloader was still the -universal U-Boot 2010.06, which does not scan the NOR layout, so the wizard never gave them the split install (scansLayout) and fell back to fixed slots. They take u-boot-<soc>-nor.bin (OpenIPC/u-boot 2022.10, scanning; cv300 also -nand.bin), as defib does since OpenIPC/defib#158. The test index lists those images, the boards reference names them, the golden is regenerated for the two SoCs, and the test that used hi3516cv300 as its -universal example uses hi3516cv200. go test ./... (uncached) passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firmware now publishes split NOR packages for these SoCs, and the catalogue did not know:
-splitonly (hi3516ev300: the split NOR image only, like hi3516cv6xx firmware#2656); hi3516ev300 neo stays fixed-slot.-splitbeside the fixed-slot package.All get
nor_split: true, so each edition uses its split package where no plain one is published, and its fixed-slot one where it is. Notnor_split_only: that would drop hi3516ev300's fixed-slot neo from the installer.Test data: the release index carries the two hi3516ev300 split packages and no plain lite/ultimate; the golden is regenerated (hi3516ev300 still offers NOR lite, ultimate, neo and NAND ultimate, lite and ultimate as split images). Two firmware tests and a wizard test that used hi3516ev300 as their fixed-slot NOR example now use hi3516ev200.
go test ./...passes (uncached).Effect order: for hi3516ev300 and hi3518ev300 the change shows once their plain
openipc.<soc>-nor-{lite,ultimate}.tgzare gone from OpenIPC/firmwarelatest(the next nightly publishes the split ones; the stale plain ones then need deleting).