Skip to content

Replace webview based tags control - #437

Open
mgaffigan wants to merge 2 commits into
OpenIntegrationEngine:mainfrom
mgaffigan:chore/replace-tags-control
Open

Replace webview based tags control#437
mgaffigan wants to merge 2 commits into
OpenIntegrationEngine:mainfrom
mgaffigan:chore/replace-tags-control

Conversation

@mgaffigan

@mgaffigan mgaffigan commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Reduces the JavaFX based WebView + JQuery + Swing tags control to only use swing. I think the prior webview design was to "test the waters" for using WebView and JFX, not as an actual requirement.

Performance impact is good. Drops idle CPU usage from ~2% to ~0.2%, drops memory usage by ~100 MB. Improves MacOS "power score" for the application by 88% - so there should be some benefit to battery life.

# JFX + Swing
PID    COMMAND      %CPU TIME     #TH  #WQ  #POR MEM   PURG   CMPRS PGRP  PPID  STATE    BOOSTS       %CPU_ME  %CPU_OTHRS UID  FAULTS  COW   MSGSENT MSGREC SYSBSD  SYSMACH  CSW     PAGEI IDLE POWE INSTRS     CYCLES     JETP USER      #MRE RPRV VPRV VSIZ KPRV KSHR
81628  java         1.7  00:22.42 69   6    603  705M- 0B     205M+ 23046 23046 sleeping *0[53]       0.00000  0.00000    501  131305+ 1240  222671+ 74193+ 406468+ 1053894+ 292558+ 2893  0    1.7  23205203   31604071   180  mgaffigan N/A  N/A  N/A  N/A  N/A  N/A

# Swing only
PID    COMMAND      %CPU TIME     #TH  #WQ  #POR MEM   PURG   CMPRS PGRP  PPID  STATE    BOOSTS      %CPU_ME %CPU_OTHRS UID  FAULTS COW  MSGSENT MSGREC SYSBSD  SYSMACH CSW     PAGE IDLE POWE INSTRS     CYCLES    JETP USER      #MRE RPRV VPRV VSIZ KPRV KS
73675  java         0.2  00:15.26 60   6    557  594M 0B   476M+ 23046 23046 sleeping *0[64]     0.00000 0.00000    501  77644+ 1068 156512 62181 272044+ 651105 163880+ 215  0    0.2  2365380 5108003 180  mgaffigan N/A  N/A  N/A  N/A  N/A  N/A

Also includes a drive-by fix for a bug where tag colors would oscillate on refresh if you had a channel and tag named the same thing.

Old New
image image
image image

Not a direct fix, but would close #434

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Test Results

121 files  ±0  121 suites  ±0   1m 47s ⏱️ +5s
677 tests ±0  677 ✅ ±0  0 💤 ±0  0 ❌ ±0 
689 runs  ±0  689 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 71906cf. ± Comparison against base commit c93b0f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't add tags to channels

1 participant