Skip to content

feat(i18n): add Teldrive V2 driver strings - #652

Open
totza2010 wants to merge 1 commit into
OpenListTeam:mainfrom
totza2010:feat/teldrive-v2-i18n
Open

feat(i18n): add Teldrive V2 driver strings#652
totza2010 wants to merge 1 commit into
OpenListTeam:mainfrom
totza2010:feat/teldrive-v2-i18n

Conversation

@totza2010

Copy link
Copy Markdown

Summary / 摘要

Adds Teldrive V2 to src/lang/en/drivers.json: the 16 config-field and help
strings for the driver, plus its entries in the driver-name and additions index
blocks further down the file.

Pairs with OpenListTeam/OpenList#3000, which adds the
driver itself. The strings mirror the help: tags in the Go struct exactly.
English only; other locales are handled through Crowdin.

  • This PR has breaking changes.
  • This PR changes public API, config, storage format, or migration behavior.
  • This PR requires corresponding changes in related repositories.

Related repository PRs / 关联仓库 PR:

Testing / 测试

  • Built locally (bash build.sh --dev --compress --skip-i18n) and confirmed
    the new storage form renders every field with its help text.

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.

Tools used: Claude. Scope: documentation (help text wording).
Reviewed and validated; reproducible without AI tools.

Adds the "Teldrive V2" block to the English driver strings: 16 keys for the
new driver's config fields and their help text, mirroring the help: tags in
the Go struct. Other locales are handled through Crowdin.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@totza2010
totza2010 force-pushed the feat/teldrive-v2-i18n branch from 3c57ee5 to 71ace71 Compare September 1, 2026 14:26

@pikachuren pikachuren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

结论:可以合并

为 Teldrive V2 驱动补充英文文案,三处改动位置都正确:主配置块按字母序插在 TeldriveTerabox 之间,additions 索引块和驱动名索引块也都同步补上了对应条目,没有遗漏。

文案质量在这类 PR 里算相当高的,几处值得肯定:

  • chunk_size 说明写清了「向上取整到 16 的倍数、上限 2000」这类实际约束,而不是只写「分片大小」;
  • upload_concurrency 点出了「每个分片都会缓冲,因此这个值会成倍放大内存占用」,这是用户调大该值时最容易踩的坑;
  • use_share_linkshare_expire 的说明把安全影响讲得很到位——直链携带 TelDrive share token、任何拿到 URL 的人无需登录即可下载、OpenList 无法统计或吊销这些访问、且存储被移除后分享依然残留。这些都是会实际影响用户决策的信息,值得这样明写。

有一点建议确认:root_folder_path 只有标签没有 -tips。如果它的取值格式有约束(比如是否需要以 / 开头、留空代表根目录),补一条提示会更完整;如果确实一目了然,保持现状也可以。

同样需要与后端 PR 协调合并顺序:驱动未上线前这些文案不会被引用,无副作用;但驱动先上线则配置项会显示成原始字段名。

@totza2010

Copy link
Copy Markdown
Author

Thanks for reviewing.

root_folder_path tip

I'd prefer to leave it as it is, if that's alright. root_folder_path isn't a field this driver declares — it comes from the shared driver.RootPath struct that every driver embeds, so its meaning is the same everywhere in OpenList rather than something specific to TelDrive.

The file is consistent about this today: 38 drivers in drivers.json have a root_folder_path key and none of them has root_folder_path-tips. root_folder_id is the same, 45 to 0. Adding one only for Teldrive V2 would make it the single exception without telling the user anything the other 38 don't also need. If a tip for that field is wanted, it seems better as one change covering the shared field across drivers rather than smuggled in here.

Happy to add it anyway if you'd rather have it.

Merge order

Agreed, and this side is the safe one to land first: until the driver exists, nothing references these strings, so merging this PR early has no effect on anyone. Merging the backend first is the case that shows raw field names in the storage form.

So whatever suits you — this one first, or both together. Backend PR is OpenListTeam/OpenList#3000.

For context, the use_share_link and share_expire wording you highlighted was tightened in response to the review on the backend PR, which asked that the security implications of handing out a share token be spelled out for the user. Good to know it reads clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants