Repository navigation
Conversation
|
|
||
| module Service | ||
| module Failover | ||
| module Failover |
There was a problem hiding this comment.
let's keep 4 spaces everywhere, I thought it's kind of dogma
There was a problem hiding this comment.
- let's try to avoid white-space only changes pls
xorel
left a comment
xorel
left a comment
There was a problem hiding this comment.
Apart from the indent, I think the policy routing sends too much into the tunnel.
The from rule makes every packet from that block use table 10000, which only has the throw for the block itself plus the tunnel default, so the main table is never consulted.
A public VM talking to a private VM behind the same VR, or to anything reached via a static or ONEGATE route, ends up in the tunnel.
my agent suggest this:
The usual fix is a rule from lookup main suppress_prefixlength 0 before the table 10000 rule, same pattern wg-quick uses, which lets main answer for everything except its default route. The throw routes then are not needed.
* Update tests * Fix forwarding enable * Fix startup ordering Signed-off-by: Victor Hansson <vhansson@opennebula.io>
* Restore existing Failover formatting * Use four-space indentation * Simplify tests Signed-off-by: Victor Hansson <vhansson@opennebula.io>
|
LGTM |
Add GRE tunnel support to VRouter
Validate configuration, enable tunnel forwarding, and order startup after Router4 and sysctl
Add GRE functionality tests
Format/Lint changes in appliances/VRouter/Failover/execute.rb