Repository navigation
F #-: VRouter: FRR: Dynamic Routing with BGP and OSPF - #416
Open
netaviator wants to merge 4 commits into
Open
netaviator wants to merge 4 commits into
netaviator wants to merge 4 commits into
Conversation
…tributes The VRouter cannot talk to upstream routers dynamically. Add an FRR module that runs bgpd, ospfd and bfdd next to the existing services and builds /etc/frr/frr.conf from attributes. Nothing changes unless it is turned on. The attributes come from the VM context at boot (ONEAPP_VNF_BGP_*, ONEAPP_VNF_OSPF_*, ONEAPP_VNF_FRR_ROUTER_ID, ONEAPP_VNF_STATIC_ROUTES) and, while the VM runs, from the VM user template through OneGate. A change is checked with frr-reload.py --test and then loaded with --reload, so other neighbors keep their sessions. If the reload fails, the last good config is loaded again. A failed apply is retried with a growing delay. BGP has IPv4 and IPv6 neighbors with password, BFD, prefix filters, local pref, MED and prepend. OSPF is OSPFv2 with area, cost, passive, timers, MD5 key and BFD per interface, an optional default route and redistribution of connected and static routes. On the VRRP backup, BGP gets a longer AS path and a higher MED, and OSPF a higher cost and metric, so peers prefer the master. This needs the failover hooks (OpenNebula#405). The backup settings are switched by a hook in /etc/one-appliance/ha-hooks.d, which Failover has to call. Without OpenNebula#405 the hook is installed but never run, and both nodes stay on the master settings. The service template is not part of this. The marketplace template needs an input for each attribute it should offer; the README lists them. There is no limit on the number of neighbors or OSPF interfaces in the module. Checked with 483 unit specs, 28 of which compare the generated frr.conf with stored files, and with real FRR 10.2.1 in Docker (sessions, filters, live changes, rollback, the backup settings, OSPF, install and configure on Alpine). It was also tested live on VMs with several instances and external peering. Signed-off-by: Jan Gilla <jgilla@level66.network>
Graceful restart (helper only): ONEAPP_VNF_BGP_GRACEFUL_RESTART=NO|HELPER, GR_RESTART_TIME and GR_STALEPATH_TIME. The setting is read at boot only. ECMP: ONEAPP_VNF_BGP_MAXIMUM_PATHS, MAXIMUM_PATHS_IBGP and MULTIPATH_RELAX, plus static routes to the same prefix with different gateways. Identical gateway pairs are rejected as duplicates. Signed-off-by: Jan Gilla <jgilla@level66.network>
The hooks are in PR OpenNebula#415. Also name the test image as a Docker image. Signed-off-by: Jan Gilla <jgilla@level66.network>
zebra turns IPv4 and IPv6 forwarding on when it starts, so the standby forwards while FRR runs. The README said the standby has forwarding stopped. Signed-off-by: Jan Gilla <jgilla@level66.network>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dynamic routing to the VRouter, with BGP and OSPF as options. The router can then exchange routes with upstream and internal routers instead of relying on static routes.
Tuning options: BFD for quicker failover, ECMP to use multiple paths in parallel, and graceful restart (helper mode) so routes are kept while a neighbor restarts.
VRRP integration: the active router is preferred. On the standby, BGP gets a longer AS path and a higher MED, and OSPF a higher cost, so peers send traffic to the active router. The standby settings are switched by a hook in /etc/one-appliance/ha-hooks.d, so this needs the failover hooks (#415).
The module runs bgpd, ospfd and bfdd next to the existing services and builds /etc/frr/frr.conf from ONEAPP_VNF_BGP_, ONEAPP_VNF_OSPF_, ONEAPP_VNF_FRR_ROUTER_ID and ONEAPP_VNF_STATIC_ROUTES. The attributes come from the VM context at boot and, while the VM runs, from the VM user template through OneGate. A change is checked with frr-reload.py --test and then loaded with --reload, so other neighbors keep their sessions. If the reload fails, the last good config is loaded again. Nothing changes unless it is turned on. The README lists all attributes.
The service template is not part of this. The marketplace template needs an input for each attribute it should offer.