Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reworks the addon bridge topology from one isolated bridge multiplexing multiple frames to one isolated bridge per exact frame/document as the correctness and security baseline.
This closes the cross-origin bootstrap and lifetime confusion window created when a shared bridge had to hand capabilities across frame boundaries. Browser-owned endpoint identity is now bound to
tabId,frameId,documentId, origin, and the exact runtime Port. Session ownership, persistence scope, picker state, and Permissions Policy evaluation follow that exact document lifetime.The PR also:
opaque|<topOrigin>|<sourceOrigin>nullas non-persistableallow="hid"allowlists for the exact child origin/documentThere is no storage schema version change. IndexedDB remains version 2,
STORAGE_SCHEMA_VERSIONremains 1, and the existing settings key structure is unchanged. The only new persisted scope form is the canonical opaque key above.Related issue(s)
N/A
Type of change
Testing
Added and extended addon coverage for:
Rust (daemon, NM host, mock)
cargo build --releasepasses, if the change touches Rust codenpm run lint:rs(cargo clippy) passes with no new warningsnpm run test:rspassesreport descriptor parsing, or the data plane
Addon (JS)
npm run lint:jsandnpm run lint(web-ext) passnpm run test:browserpasses (no hardware needed)npm run test:e2epasses if the change touches the data plane orworker-spawn paths (see E2E setup note below)
npm run test:benchmarkif the change affects throughput or latencyE2E needs the debug binaries and one-time Linux setup
(
sudo make install-e2e-udev-rule); seedocs/DEVELOPMENT.md. Running both e2e
projects concurrently requires
--workers=1.Checklist
BENCHMARK.md) if needed