Fix ipv6ll printing (w/ test) - #1687
Closed
flaviut wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1686.
Right off, I used AI tools to code this, and while I've skimmed the code and there are no obvious (to me) mistakes, I don't understand the CUPS codebase enough to fundamentally understand if this is the right approach. It does work though!
The reason I submitted this as a PR is the third commit in the series, add integration test. This adds tests that prove this entire flow, end-to-end. It might be valuable to you, if you choose to address this issue, to prove that any fix here actually works. It allows for a rapid feedback loop by just running
nix flake check.