Repository navigation
feat(src): match the Yeedil object update at 004435A0 (492 bytes) - #346
Merged
Merged
Conversation
Use the qualified SDATA alias for the incomplete shared vector view and declare 00442F80 with its actual pointer return. Its failure path returns null; the remaining paths forward the child pointers from 00443328 or 004431E0. The truthful return contract closes the last temporary-register difference without register pins, false object bounds or added accesses. Move the retained reconstruction into its G8 source unit and remove its assembly marker and obsolete near-miss entry. Record the unsuccessful SDATA follow-up on 00132028 so it is not repeated without new evidence. Validated: 492 bytes, 1/1 USA v1.01 and 1/1 USA v2.00 placements. PAL has no corresponding catalogue identity. All28 USA v1.01 programs pass the strict build, as does USA v2.00 level20; no C fallback. All294 tests, repository/progress and LF/diff checks pass. No report is regenerated.
ByteMatch progress reportSCES_516.07
No function changes. SCUS_972.68
No function changes. SCUS_972.68_v2
No function changes. Commit e3b8e27 · Ratchet & Clank: Going Commando on ByteMatch |
The newly merged functional-gate tests resolve a missing boot-function alias through copy_map, which reads the private boot image. CI has no game data, so the previously synthetic level-resolver fixture fails there. Supply an empty synthetic copy map for this fixture and explicitly reject any retail-byte read. Keep all existing resolution assertions and the separate copy-pair tests. No production resolver or matching code changes. Checked: all19 functional-gate tests pass without game data; host222 tests pass with expected skips, and the private Linux suite passes313 tests. All matching source/compiler inputs retain the qualified29-program bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Match
func_L20_004435A0, the 492-byte Yeedil object update, from its retained reconstruction. The shared vector remains an incomplete array with the qualifiedSDATAaddress view. The spawn selector now declares its actual pointer return: null on failure, otherwise the child pointer returned by one of its two helpers. This closes the last register difference with the real ABI.The obsolete near miss is retired. A separate retained note records why the same address-alias experiment does not yet close
func_00132028. No arbitrary assembly, register pin, fake extent or added operation is introduced.Checked
tools/check.py func_L20_004435A0: 1/1 US and 1/1 US2 placements match; PAL has no catalogue identity.tools/build.py all --strict --jobs 6 --version us: 28 programs OK.tools/build.py level 20 --strict --version us2: OK. These cover every carrying program; no C fallback.Adds one C function, 492 unique primary bytes, with two placements across the releases. No progress report regeneration or native gameplay test is claimed.