Repository navigation
fix(ui): ghost sentinel timestamps read as current, not 1970 - #186
Merged
Merged
Conversation
The Key Values widget, the robot header "Last seen" and the fleet chip tooltip formatted the ghost sentinel (ts = 12) with moment, so ghost robots showed "57 years ago". Treat the sentinel as "now" in those three places, matching the existing handling in lib/status.js. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
✅ Deploy Preview for ornate-croquembouche-cc5482 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ghost robots (
updateStamp/ts=HACK_GHOST_UPDATE_STAMP_VALUE, i.e.12) are already treated as never stale inlib/status.js, but three places still formatted that timestamp with moment and showed "57 years ago":Independent of #185 (the
Robotconfig kind), which is how ghosts get created; the sentinel itself predates both.Test plan
app: full suite green, client bundle compilesconfigAPI:Robot kindtest for the apply -> clear -> re-apply-without-pose sequence, left out of feat(configAPI): Robot kind, with ghost robots for demos #185 by its merge timing🤖 Generated with Claude Code