Skip to content

i18n: French translations for fr_FR coverage gaps (#238) - #305

Open
Tarekchehahde wants to merge 1 commit into
OpenSPP:19.0from
Tarekchehahde:i18n/238-french-coverage-gaps
Open

i18n: French translations for fr_FR coverage gaps (#238)#305
Tarekchehahde wants to merge 1 commit into
OpenSPP:19.0from
Tarekchehahde:i18n/238-french-coverage-gaps

Conversation

@Tarekchehahde

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Load OpenSPP with fr_FR and smoke-test Change Requests, Programs, Cycle, and Household forms
  • .po-only change

Fixes #238

Made with Cursor

Add or correct French msgstr entries across change requests, programs,
and registry modules for strings visible in fr_FR demo workflows.

Co-authored-by: Cursor <cursoragent@cursor.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the French translation files (fr.po) for the spp_change_request_v2, spp_programs, and spp_registry modules. The changes improve translation accuracy, correct grammatical errors, and replace untranslated English terms with proper French equivalents. As there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@gonzalesedwin1123 gonzalesedwin1123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — the spp_programs and spp_change_request_v2 parts of this are good work (verified: msgfmt -c passes on all three files, no placeholder issues, the French is correct and idiomatic, and there are no overlapping msgids with your #301). But this PR needs changes on four points before it can land.

Must-fix 1: drop (or redo) both spp_registry changes — they make the file less consistent

Both entries were already correct, and both edits go against the file's own conventions:

  • Ajouter des étiquettes...Ajouter des étiquettes…: the file uses three ASCII dots everywhere (7 occurrences, zero characters). This would introduce the only ellipsis character in the file.
  • Date d’enregistrementDate d'inscription: three problems at once. The file uses the typographic apostrophe throughout (72 occurrences) — this introduces an ASCII '. The file uniformly translates register/registration as enregistrement (12 occurrences, zero inscription) — including Mois d’enregistrement (Registration Month) a few lines away, which appears next to this label in the filter views, so the two would visibly disagree. And enregistrement is arguably the better term for a registry anyway.

Simplest resolution: remove spp_registry/i18n/fr.po from the PR entirely.

Must-fix 2: two inventory strings that ARE genuinely broken were missed

From #238's own inventory, in spp_programs/i18n/fr.po:

  • Recent Cycles → currently msgstr "Recent Cycles" (untranslated, inventory item 25)
  • Financial Summary → currently msgstr "Financial Résumé" (mangled, inventory item 34)

Both are on the exact screens the issue describes. Please add them (e.g. Cycles récents, Résumé financier). Related: your PR comment says "58 msgstr updates" but the branch contains 25 — worth double-checking that everything you intended to push is actually on the branch; these two may be part of what went missing.

Must-fix 3: version bumps + HISTORY entries

Same as requested on #301: micro version bump in __manifest__.py plus a readme/HISTORY.md line for each touched module (spp_programs, spp_change_request_v2; spp_registry only if any change survives must-fix 1). Model-term translations only refresh on module upgrade, and existing databases need --i18n-overwrite to overwrite the current wrong values — worth a sentence in the HISTORY entries.

Must-fix 4: change "Fixes #238" to "Partially addresses #238"

I checked the #238 inventory against the .po files, and most of it is already translatedReference, Registrant, the notebook tabs, all the demographics labels, Currency, the state badges, etc. all have correct French entries in upstream 19.0. If those rendered in English during your QA, the likely cause is that the deployment's translations weren't (re)loaded — please re-test with a module upgrade plus --i18n-overwrite before concluding strings are missing. The theme_openspp_muk/base sidebar items (inventory item 45) also aren't touched here. So this PR shouldn't auto-close #238; the issue needs a re-scope pass afterwards to separate real gaps from stale-translation artifacts in the QA environment.

Non-blocking notes

  • # BénéficiairesNb de bénéficiaires (and the # Eligible twin) changes an already-acceptable entry; fine to keep, just noting it's a style choice rather than a fix.
  • Merge order: #301 should land first (corrections-only, same spp_programs/fr.po); no msgid overlap between the two, so the rebase should be trivial.
  • CI: same situation as your other PRs — no workflows ever ran (fork approval at open time, no pushes since). Your next push will trigger it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: add French translations for ~45 strings exposed in fr_FR user sessions (spp_registry, spp_change_request_v2, theme_openspp_muk)

2 participants