E2e/add spmis tests - #474
Open
anthonymarkQA wants to merge 7 commits into
Open
Conversation
- playwright.config.ts: global test timeout down to 1 min so a frozen/
broken step in a non-install test fails fast instead of waiting out
the old 10-minute ceiling. The two install-heavy operations (the
beforeAll docker teardown/rebuild, and the app-install test itself
in both spec files) explicitly override via test.setTimeout(300_000)
since they legitimately need more room.
- Test 18 (Update ID Document CR): removed a leftover unconditional
page.pause() from the original codegen authoring — it blocked
indefinitely with nobody there to resume it, guaranteed to hit any
reasonably short timeout. Replaced a waitForLoadState("networkidle")
wait with a targeted visibility check (Odoo's persistent long-poll
connection means the network may never go fully idle). Swapped the
registrant-row locator from getByRole("cell", ...) — which silently
matched 0 elements, likely due to a CSS display override breaking
the implicit ARIA "cell" role on that specific table — to a plain
CSS class + text-content locator (tr.o_cr_search_result with
hasText), which doesn't depend on ARIA role computation at all.
- Test 19 (HQ validator user): removed two brittle whole-row-name
assertions built from concatenated column text
("Name Login Roles ", "Role Center Areas Role Type",
"CR HQ Validator Delete row") — exact-string-with-double-spaces
matches like this break on any minor layout difference and aren't
needed; the flow already fails naturally if the real elements
aren't there.
Confirmed passing end-to-end after these fixes.
Keep 19.0's flat 10-minute default (already proven in real CI) instead of the shorter global default + per-test overrides explored on this branch. Keeps the unrelated afterAll page guard and all the new test content. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Each matrix job wrote its result to the same status/result.json name before uploading, so the notify job's merge-multiple download silently overwrote one job's result with the other. Give each job's result file a unique name and add the Repository/Ref/Spec-files fields the notification was originally designed to include. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
These spec files can't run in parallel workers anyway (each is one serial browser session sharing a single Docker stack), so Playwright's "slow test file, consider running in parallel" note is just noise here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- login() now handles Odoo's avatar-picker login screen, which appears once 2+ accounts have logged in during the browser session (from test 20 onward), instead of only the plain form - import tests (22, 23) set files via input[type="file"] directly instead of clicking "Upload Data File" first, which was triggering a real OS file dialog Playwright can't control - test 23 drops a fragile "tags_ids" row wait in favor of the actual post-import success alert - CI's Discord notification now lists each test step with a pass/fail mark per spec file, via a new Playwright JSON reporter Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #474 +/- ##
=======================================
Coverage 75.93% 75.93%
=======================================
Files 627 627
Lines 43000 43000
=======================================
Hits 32654 32654
Misses 10346 10346
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Add additional tests for SPMIS:
How was the change implemented?
New unit tests
Unit tests executed by the author
How to test manually
pull this branch
cd into e2e
npx playwright test 01-spp-starter-spmis.spec.ts
for discord webhook , it will be tested once this PR successfully merged to 19.0
Related links