feat: add manually selectable skateboarding - #454
highdeftant wants to merge 1 commit into
Conversation
Reviewer's GuideIntroduces manually selectable Skateboarding as a GPS-enabled, distance-tracked outdoor activity using the 2011 Compendium’s 5.0 MET estimate, adds its route type, and preserves cross-platform health export compatibility through the OTHER fallback while retaining the Skateboarding title. Flow diagram for manually selected skateboarding workoutflowchart LR
User[User selects Skateboarding] --> Activity[Skateboarding activity]
Activity --> GPS[GPS route capture]
Activity --> Distance[Distance tracking]
Activity --> Calories[Estimated calories from 5.0 MET]
Activity --> HR[Cardiovascular strain from HR path]
Activity --> Export[Health export]
Export --> Other[OTHER workout type]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: OpenStrap/edge/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe activity catalogue adds skateboarding as an Outdoor activity with distance tracking, a 5.0 MET value, and GPS enabled. The route-bearing activity keys now include skateboarding. ChangesSkateboarding activity
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Skateboarding can be selected, recorded with GPS when permitted, and exported with its title. The reviewed changes show no actionable merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The reviewed changes support the core objectives in [ ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the new activity mapping or 5.0 MET estimate is wrong, users can create persisted skateboarding sessions and GPS routes with incorrect activity data. Reverting stops new records but does not remove those already stored, though the bounded records can be corrected or deleted.
|
Closing for now per author request; keeping the fork branch as a local prototype while we do the activity research and chart design work. |
1 participant
Closes #453
Adds skateboarding as a manually selectable Outdoor activity, with GPS route capture and the 2011 Adult Compendium's 5.0 MET value for general moderate-effort skateboarding (code 15580). MET-based calories remain estimates; workout cardiovascular strain still comes from the existing HR path. No automatic skateboard detection is added.
The installed
health12.2.1 enum does not expose a skateboard-specific workout type, so exports use the existing cross-platformOTHERfallback while retaining the Skateboarding workout title.Tests:
fvm flutter test test/ui2_activity_test.dart test/workout_health_mapping_test.dart test/route_types_match_catalogue_test.dart;fvm dart analyzeon the changed Dart files;git diff --check.Summary by Sourcery
Add manually selectable skateboarding activity support with route capture and health export compatibility.
New Features:
Enhancements:
Tests:
Summary by CodeRabbit