Enhance framebuffer handling for Abcom EGL build and adjust resolution change application in gEGLDC - #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues related to framebuffer handling and resolution changes, specifically for the Abcom EGL platform (hifb + Mali fbdev). The main improvements ensure that framebuffer memory is properly cleared and remapped during resolution changes, and that pending resolution changes are applied at the correct time to avoid rendering glitches.
Framebuffer and resolution handling improvements:
fbClass::SetMode, for the Abcom EGL build, the framebuffer is now remapped if the video memory size changes, and all framebuffer pages are cleared to prevent stale images from being displayed.gEGLDC::exec, pending resolution changes are now applied before processing the first opcode aftersetResolution(), ensuring that new content is correctly painted into the new framebuffer target.Code cleanup:
AbcomWindowProvider::canResizeWindow()for minor code tidiness.