[skin] only display color buttons when there is a label available - #1353
Merged
Merged
Conversation
xcentaurix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the button bar so it only shows color buttons that have a label.
Cause. The red, yellow and blue markers appeared because the bar decides what to show differently for two kinds of button:
For text sources (StaticText), a button counts as present only if its text is non-empty.
For plain button components (Button), it only checked visible. That is always true. EventView creates its unused buttons as Button(""), so they were drawn as bare coloured markers.
Fix. In constructButtonSequence in ScreenButtonsBar.py, a visible button component now also needs non-empty text:
... or hasattr(val, "visible") and val.visible and val.text):