fix(climate): omit unsupported 'off' from fancoil fan modes (#410) - #412
Merged
GreenGrassBlueOcean merged 1 commit intoSep 19, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GreenGrassBlueOcean
requested review from
xtimmy86x
and removed request for
xtimmy86x
September 18, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #410. Related to OpenWebNet-HA/openwebnet-mcp#1.
Root Cause
In OpenWebNet WHO=4 (Temperature Control) specifications, Dimension 11 (
Fan coil Speed) status values are0=Auto,1=Speed 1,2=Speed 2,3=Speed 3, and15=OFF (read-only status).Speed code
4was a legacy non-standard placeholder which does not exist in the BTicino OpenWebNet protocol and is silently dropped by physical gateways (e.g. F461). Furthermore, physical thermostats (such as LN4691, 3550) only cycleAuto -> Speed 1 -> Speed 2 -> Speed 3 -> Autowithout an independentofffan mode while active; fancoils are stopped automatically by actuator idle state (Dimension 20, Val 5) when target temperature is reached or when setting the zone toHVACMode.OFF.Changes
custom_components/myhome/climate.py:"off"from_attr_fan_modes. The list of supported fan modes is now["auto", "low", "medium", "high"]."off": 4fromfan_mode_mapinasync_set_fan_mode().fan_on=Falseor15update actuator state attributes (running_fan_speed) rather than overwriting target preset_attr_fan_mode.tests/test_component_climate.py,tests/test_issue_303.py, andtests/test_trace_replay.pyto match the 4 supported fan modes."off"fan mode raisesServiceValidationError.custom_components/myhome.