Refactor hex and int string conversion methods - #41
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GreenGrassBlueOcean
self-requested a review
September 17, 2026 08:04
GreenGrassBlueOcean
approved these changes
Sep 17, 2026
GreenGrassBlueOcean
left a comment
GreenGrassBlueOcean
left a comment
Contributor
There was a problem hiding this comment.
Great refactor! Replacing the manual string concatenations with generator expressions and "".join() makes the code much more Pythonic and efficient. I've verified that this maintains 100% functional parity with the original methods, correctly preserving the OpenWebNet protocol's specific padding requirements. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.