Skip to content

fix(connection): log status request NACK retries at DEBUG (#43) #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xtimmy86x merged 1 commit into from
Sep 18, 2026
Merged

fix(connection): log status request NACK retries at DEBUG (#43) #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions OWNd/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,12 +1389,20 @@ async def _locked_send(
message,
)
return None
self._logger.error(
"%s Could not send message `%s`. Retrying (%d)...",
self._log_id,
message,
attempt,
)
if is_status_request:
self._logger.debug(
"%s Status request `%s` not acknowledged (NACK). Retrying (%d)...",
self._log_id,
message,
attempt,
)
else:
self._logger.error(
"%s Could not send message `%s`. Retrying (%d)...",
self._log_id,
message,
attempt,
)
continue

self._logger.warning(
Expand Down
7 changes: 7 additions & 0 deletions tests/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,13 @@ async def test_rejected_status_request_is_logged_at_debug() -> None:

assert result is None
assert writer.written == [b"*#16*0##", b"*#16*0##"]
logger.error.assert_not_called()
logger.debug.assert_any_call(
"%s Status request `%s` not acknowledged (NACK). Retrying (%d)...",
session._log_id,
"*#16*0##",
1,
)
logger.debug.assert_any_call(
"%s Gateway rejected status request %s (NACK, %s response(s)). Subsystem or device may not be present.",
session._log_id,
Expand Down
Loading