Repository navigation
test(coop): wait for the Ufopaedia section button in the craft deployment test - #236
Merged
Merged
Conversation
…eview drive clicks it The craft deployment test opens the Ufopaedia and clicks "X-COM CRAFT" after a fixed 0.3 s settle. UfopaediaStartState opens as a popup window, which hides every button for about 20 frames (about 0.3 s at the 15.6 ms Windows tick). A hidden button drops the click, click_widget still answers ok, and the row fails with an empty craft list. It failed one of three local runs on main. With the start screen held at 50 ms frames (slow_top), the button reads hidden at every click and five rows fail, 3 of 3 runs. The drive now waits with session.wait_widget_ready, as test_preview_restream already does, and passes 8 of 8 under the same slow frames on both harness slots and 20 of 20 plain runs.
NonPolynomialTim
enabled auto-merge (squash)
November 6, 2026 02:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/coop_test/test_shared_craft_deployment.pysometimes fails a row withpreview drive craft_section ... ['X-COM CRAFT & ARMAMENT', []]. It failedcraft_deploy_separatein one of three local runs on main (8ccc045).Cause
The preview drive opens the Ufopaedia and clicks "X-COM CRAFT" after a fixed 0.3 s settle.
UfopaediaStartStateopens as a popup window (POPUP_BOTH), which hides every button while it opens. That takes about 20 frames, or about 0.3 s at the 15.6 ms Windows tick. A hidden button drops the click, andclick_widgetstill answers ok. In the failing run, the client's log showsUfopaediaStartStatepushed and noUfopaediaSelectStateafter the click.Evidence: with the start screen held at 50 ms frames (
slow_top {type: UfopaediaStartState, ms: 50}),list_widgetsread right before each click shows the button as{"visible": true, "hidden": true}. Every click returnsok: true, the select screen never opens, and five rows fail:craft_deploy_1tocraft_deploy_4andcraft_deploy_separate. That happened in 3 of 3 runs.Fix
Test-only. The drive now calls
session.wait_widget_ready(gc, "X-COM CRAFT")before the click, the same waittest_preview_restream.pyandtest_client_research.pyuse. If the button never shows, thecraft_sectionmiss now records the wait result. The other screens the drive clicks (the select list, the craft article, INFO, the abort box) are not popup windows, and the drive already waits for each one to be on top.Test
hidden: falseat every click.